Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ascii85 off by one #333

Closed
wants to merge 6 commits into from
Closed

Feature/ascii85 off by one #333

wants to merge 6 commits into from

Conversation

speedplane
Copy link

ASCII 85 can represent 2^32-1. This error was causing validations to break.

Note that this merge requires #332 to be merged first to be a nice clean merge.

@vstoykov
Copy link
Contributor

It will be best if this changes was against this projects master instead of your master, because will be easier to be merged even if the changes from your other PR are not accepted.

@MartinThoma MartinThoma added is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF Tiny Pull requests that make a tiny change - and thus should be easy to merge labels Apr 6, 2022
@MartinThoma
Copy link
Member

I think this is related to #312

@MartinThoma MartinThoma linked an issue Apr 9, 2022 that may be closed by this pull request
Assertion error in function ASCII85Decode.decode #312
Closed
@MartinThoma
Copy link
Member

Note that this merge requires #332 to be merged first to be a nice clean merge.

Why that?

@MartinThoma
Copy link
Member

Does anybody happen to have a PDF file with /ASCII85Decode data streams that we could use for testing?

@MartinThoma MartinThoma added the needs-test A test should be added before this PR is merged. label Apr 9, 2022
MartinThoma added a commit that referenced this pull request Apr 10, 2022
@MartinThoma
BUG: Fix ASCII85Decode.decode assertion
7f2d558 
BUG: Off-by-one
FIX: Set 2**32-1 inclusive

Closes #312

Credits to Michael Sander (speedplane) who
included it here:
#333
@MartinThoma MartinThoma mentioned this pull request Apr 10, 2022
Merged
MartinThoma added a commit that referenced this pull request Apr 10, 2022
@MartinThoma
BUG: Fix ASCII85Decode.decode assertion (#729)
8f8e0ae 
BUG: Off-by-one
FIX: Set 2**32-1 inclusive

Closes #312

Credits to Michael Sander (speedplane) who
included it here:
#333
@MartinThoma
Copy link
Member

The current state is not compatible with main. Would you mind to fix the merge conflicts?

@MartinThoma MartinThoma added the needs-change The PR/issue cannot be handled as issue and needs to be improved label Apr 16, 2022
@MartinThoma MartinThoma removed this from the Last PyPDF2 version 1.X release milestone Apr 21, 2022
@MartinThoma
Copy link
Member

I think the main point of this PR was already adressed elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF needs-change The PR/issue cannot be handled as issue and needs to be improved needs-test A test should be added before this PR is merged. Tiny Pull requests that make a tiny change - and thus should be easy to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion error in function ASCII85Decode.decode
3 participants
@speedplane @vstoykov @MartinThoma