-
Notifications
You must be signed in to change notification settings - Fork 1.5k
STY: Import PageAttributes as PG not PA #3402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For codebase consistency.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3402 +/- ##
==========================================
- Coverage 96.96% 96.95% -0.01%
==========================================
Files 55 55
Lines 9343 9341 -2
Branches 1708 1708
==========================================
- Hits 9059 9057 -2
Misses 169 169
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I would prefer to refactor all calls to use |
|
Agree; the reason I found this was because of confusion about PA vs PG. Suggestions:
|
|
Another thought: Do we need these abbreviations at all? Or could we just use the full name here to avoid confusion completely? |
|
Like it. In this PR could do this:
Then codebase is consistent, and any further removal done in other PRs. |
For codebase consistency.