Skip to content

Conversation

@j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jul 29, 2025

For codebase consistency.

For codebase consistency.
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.95%. Comparing base (01c98a5) to head (67acbff).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3402      +/-   ##
==========================================
- Coverage   96.96%   96.95%   -0.01%     
==========================================
  Files          55       55              
  Lines        9343     9341       -2     
  Branches     1708     1708              
==========================================
- Hits         9059     9057       -2     
  Misses        169      169              
  Partials      115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846
Copy link
Collaborator

I would prefer to refactor all calls to use PageAttributes as PA - PG is somehow confusing in this context. This will conflict with PagesAttributes currently being imported as PA, thus it might need further discussions.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jul 29, 2025

Agree; the reason I found this was because of confusion about PA vs PG.

Suggestions:

from .constants import PagesAttributes

from .constants import PagesAttributes as PPA

@stefan6419846
Copy link
Collaborator

Another thought: Do we need these abbreviations at all? Or could we just use the full name here to avoid confusion completely?

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jul 29, 2025

Like it.

In this PR could do this:

from .constants import PagesAttributes as PA -> from .constants import PagesAttributes

Then codebase is consistent, and any further removal done in other PRs.

stefan6419846
stefan6419846 previously approved these changes Jul 31, 2025
@stefan6419846 stefan6419846 merged commit 1173037 into py-pdf:main Jul 31, 2025
16 checks passed
@j-t-1 j-t-1 deleted the PageAttributes branch August 1, 2025 06:06
j-t-1 added a commit to j-t-1/pypdf that referenced this pull request Aug 5, 2025
OpenNingia pushed a commit to OpenNingia/pypdf that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants