Skip to content

Conversation

@j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jul 31, 2025

params.group is not always equal to 4, so the comment is changed.

params.group is not always equal to 4, so the comment is changed.
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.95%. Comparing base (01c98a5) to head (7dda4cb).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3416      +/-   ##
==========================================
- Coverage   96.96%   96.95%   -0.01%     
==========================================
  Files          55       55              
  Lines        9343     9340       -3     
  Branches     1708     1708              
==========================================
- Hits         9059     9056       -3     
  Misses        169      169              
  Partials      115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846
Copy link
Collaborator

Arbitrarily grouping list values in lines is usually a bad idea, especially since if we ever decide to apply an auto-formatter, this would lead to issues.

If it is unclear that these are grouped, we might consider moving the comments from behind the first value to a dedicated line before the first value of the group.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Aug 1, 2025

I disagree. But will revert them in single lines to get the small changes done.

@stefan6419846 stefan6419846 merged commit 293602d into py-pdf:main Aug 4, 2025
16 checks passed
@j-t-1 j-t-1 deleted the tiff branch August 4, 2025 10:30
j-t-1 added a commit to j-t-1/pypdf that referenced this pull request Aug 5, 2025
params.group is not always equal to 4, so the comment is changed.
OpenNingia pushed a commit to OpenNingia/pypdf that referenced this pull request Oct 23, 2025
params.group is not always equal to 4, so the comment is changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants