forked from camelot-dev/camelot
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Should we enabling typing across the repo? #96
Labels
question
Further information is requested
Comments
justshrey
changed the title
[Question] Should we be enabling typing across the repo?
[Question] Should we enabling typing across the repo?
Aug 29, 2024
Hi, I'll welcome the pr. |
With this PR #190 , mypy type testing is added to github actions. The strict option will not pass the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I saw that there has been typing enabled in the PR (Add typing for camelot/backends) #12 for the backend. Wanted to know if we plan to do this across the repo? Happy to submit a pull request if that's something that we would like in the repo?
Am guessing it would be better to do this after merging existing pull requests and the work around rebranding?
The text was updated successfully, but these errors were encountered: