Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate mypy type checking #190

Merged
merged 5 commits into from
Oct 19, 2024
Merged

Activate mypy type checking #190

merged 5 commits into from
Oct 19, 2024
+88 −22

Conversation

bosd
Copy link
Collaborator

@bosd bosd commented Oct 19, 2024

  • Activate mypy test on github actions
  • Add typing_extensions dependency for python < 3.11
  • Some typing fixes to make mypy pass
  • Added instructions from mypy readme, to graduallly improve typing on existing code base.

Fasttracking this one, to be able to rebase code-refactors so pre-commit can be activated on this repo.

@bosd bosd added ci Continuous Integration dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code python Pull requests that update Python code refactoring Refactoring labels Oct 19, 2024
@bosd bosd changed the title Activate Mypy typing Activate mypy type checking Oct 19, 2024
@bosd bosd merged commit 90b48d4 into py-pdf:main Oct 19, 2024
13 checks passed
@bosd bosd deleted the t-pre-commit-2 branch October 19, 2024 10:55
@bosd bosd mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code python Pull requests that update Python code refactoring Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bosd