Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] split_textline #178

Merged
merged 2 commits into from
Oct 19, 2024
Merged

[REF] split_textline #178

merged 2 commits into from
Oct 19, 2024

Conversation

bosd
Copy link
Collaborator

@bosd bosd commented Oct 12, 2024

  1. Modular Functions: The code is broken down into smaller functions (_process_horizontal_cut, _process_vertical_cut, and _group_and_process_chars) to handle specific tasks, making it easier to read and maintain.
  2. Error Handling: The try-except block was removed since the logic handles cases gracefully without needing to catch exceptions.
  3. Type Hints: Type hints were added for better code clarity and to help with type checking.

@bosd bosd added the refactoring Refactoring label Oct 12, 2024
@bosd bosd marked this pull request as ready for review October 12, 2024 15:26
@bosd bosd force-pushed the ref-split-textline branch 3 times, most recently from e878410 to 2151860 Compare October 19, 2024 13:47
1. **Modular Functions**: The code is broken down into smaller functions (`_process_horizontal_cut`, `_process_vertical_cut`, and `_group_and_process_chars`) to handle specific tasks, making it easier to read and maintain.
2. **Error Handling**: The try-except block was removed since the logic handles cases gracefully without needing to catch exceptions.
3. **Type Hints**: Type hints were added for better code clarity and to help with type checking.
@bosd bosd merged commit 25f08cc into py-pdf:main Oct 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant