Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Fix pytest warning on retun while testing_plot #57

Closed
wants to merge 1 commit into from
Closed

[IMP] Fix pytest warning on retun while testing_plot #57

wants to merge 1 commit into from

Conversation

bosd
Copy link
Collaborator

@bosd bosd commented Aug 20, 2024

before:

tests/test_plotting.py::test_textedge_plot
  /Users/runner/work/pypdf_table_extraction/pypdf_table_extraction/.nox/tests-3-10/lib/python3.10/site-packages/_pytest/python.py:163: PytestReturnNotNoneWarning: Expected None, but tests/test_plotting.py::test_textedge_plot returned <Figure size 640x480 with 1 Axes>, which will be an error in a future version of pytest.  Did you mean to use `assert` instead of `return`?

image

@bosd bosd added ci Continuous Integration testing Testing labels Aug 20, 2024
@bosd bosd closed this Aug 21, 2024
@bosd
Copy link
Collaborator Author

bosd commented Aug 21, 2024

Closed in favor of #60

@bosd bosd deleted the fix-pytest-warnings branch August 21, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Continuous Integration testing Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bosd