Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example application using the mixer API #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zmarvel
Copy link
Contributor

@zmarvel zmarvel commented Oct 14, 2019

  • Example application using mixer API
  • Added one sound effect and a looping chiptune to examples/resources, with credits

On Debian 10, running this example depends on #143.

@a-hurst a-hurst self-assigned this Nov 23, 2019
@a-hurst
Copy link
Member

a-hurst commented Nov 23, 2019

This looks great! This will be very helpful for newcomers trying to wrap their heads around SDL2_mixer's arcane audio API.

Two requests before I merge this:

  • First, can you make the coin noise louder relative to the music? It's a little hard to hear on my (admittedly terrible) ThinkPad speakers, but it's an important part of the demo. Adjusting the volume of either the music or coin noise would also be a helpful illustration for the example, too.
  • Second, would it be possible to compress the music as .ogg and have the coin noise as the .WAV example instead? I only ask because including it adds 2MB of bulk to a repository that's only 3.5MB total to begin with, and I'd like to keep things lean.

Thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants