Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and add num_nodes and verbose options to get_top_moves() #16

Merged
merged 39 commits into from
Apr 20, 2023
Merged

Refactor and add num_nodes and verbose options to get_top_moves() #16

merged 39 commits into from
Apr 20, 2023

Commits on Sep 29, 2022

  1. Add include_info=True flag to .get_top_moves() 

    lint with black

add dict type

more elaborate typing

type

type this

ignore type

fixed

Separete moves, info in Tuple if include_info=True

lint with black

add test

revert; add test

fix test

cleanup
    @knutole
    knutole committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    8a5ebdc View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Update stockfish/models.py 

    Add suggested cleanup

Co-authored-by: kieferro <81773954+kieferro@users.noreply.github.com>
    @knutole @kieferro
    knutole and kieferro committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c201434 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Update readme with include_info flag

    @knutole
    knutole committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0906d2e View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Refactor get_top_moves(): 

    - Add support for 'num_nodes', see #14
- Add suppoert for 'verbose', see #15
- Refactor get_top_moves, remove redundant code
- Add tests for new arguments
- Rename 'N/s' to 'NodesPerSecond'
- Add turn_perspective global option
- Add get/set for self._num_nodes
- Add get/set for self._turn_perspective
- Todo: Refactor turn_perspective option for rest of codebase
    @knutole
    knutole committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    bb0800d View commit details
    Browse the repository at this point in the history

  2. Update README. Cleanup.

    @knutole
    knutole committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    53e23e8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into improve_get_top_moves

    @knutole
    knutole committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    0b0eadb View commit details
    Browse the repository at this point in the history

  4. lint with black

    @knutole
    knutole committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    aad00a5 View commit details
    Browse the repository at this point in the history

  5. Rename to is_turn_perspective; cleanup

    @knutole
    knutole committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    666113f View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2023

  1. Remove unnecessary depth arg

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    cb0750f View commit details
    Browse the repository at this point in the history

  2. Remove tests for get_top_moves(depth)

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    b81106b View commit details
    Browse the repository at this point in the history

  3. Update tests

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    5650fab View commit details
    Browse the repository at this point in the history

  4. Use self._depth as int, add public getter 

    - Fixes #8
    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    29e2f33 View commit details
    Browse the repository at this point in the history

  5. Add type check for .set_depth(); add tests

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    48a3725 View commit details
    Browse the repository at this point in the history

  6. Add type check for .set_num_nodes(); add tests

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    99efaa4 View commit details
    Browse the repository at this point in the history

  7. Add type check for .set_is_turn_perspective(); add tests

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    aa07dbd View commit details
    Browse the repository at this point in the history

  8. Add types to new options

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    8e34653 View commit details
    Browse the repository at this point in the history

  9. Use public functions to set depth, num_nodes, is_turn_perspective to … 

    …ensure type checking
    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    4dc39c2 View commit details
    Browse the repository at this point in the history

  10. Fix grammar

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    1399db7 View commit details
    Browse the repository at this point in the history

  11. Add tests for instantiating Stockfish class

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    2663e6f View commit details
    Browse the repository at this point in the history

  12. Add test coverage for some missing lines

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    c95a88e View commit details
    Browse the repository at this point in the history

  13. Cleanup test names

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    bf8af50 View commit details
    Browse the repository at this point in the history

  14. Fix minor cosmetic issues

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    6513973 View commit details
    Browse the repository at this point in the history

  15. Rename is_turn_perspective -> get/set turn_perspective

    @knutole
    knutole committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    6b09ab4 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2023

  1. Use update_parameters_attribute of _set_option()

    @knutole
    knutole committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    29eb5b8 View commit details
    Browse the repository at this point in the history

  2. Make use of default arg for _set_option; add tests for _set_option

    @knutole
    knutole committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    b7a7fe7 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Add convenience method _pick()

    @knutole
    knutole committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    61e00e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Split tests 

    Co-authored-by: kieferro <81773954+kieferro@users.noreply.github.com>
    @knutole @kieferro
    knutole and kieferro committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    61288e9 View commit details
    Browse the repository at this point in the history

  2. Split tests 

    Co-authored-by: kieferro <81773954+kieferro@users.noreply.github.com>
    @knutole @kieferro
    knutole and kieferro committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    89690fc View commit details
    Browse the repository at this point in the history

  3. Remove default list in _pick 

    Co-authored-by: kieferro <81773954+kieferro@users.noreply.github.com>
    @knutole @kieferro
    knutole and kieferro committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    94ad50d View commit details
    Browse the repository at this point in the history

  4. Fix typo 

    Co-authored-by: kieferro <81773954+kieferro@users.noreply.github.com>
    @knutole @kieferro
    knutole and kieferro committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    ee945dc View commit details
    Browse the repository at this point in the history

  5. Fix typo 

    Co-authored-by: kieferro <81773954+kieferro@users.noreply.github.com>
    @knutole @kieferro
    knutole and kieferro committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    22cc3e3 View commit details
    Browse the repository at this point in the history

  6. Fix typo 

    Co-authored-by: kieferro <81773954+kieferro@users.noreply.github.com>
    @knutole @kieferro
    knutole and kieferro committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    996afa2 View commit details
    Browse the repository at this point in the history

  7. Update text

    @knutole
    knutole committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    8c9e95e View commit details
    Browse the repository at this point in the history

  8. Lint

    @knutole
    knutole committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    45f50ac View commit details
    Browse the repository at this point in the history

  9. Lint with black

    @knutole
    knutole committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    028e4da View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Review: update README, parametrize tests

    @knutole
    knutole committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    3fdfec4 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @knutole
    knutole committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    fcc198a View commit details
    Browse the repository at this point in the history

  3. Remove comments

    @knutole
    knutole committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a33579d View commit details
    Browse the repository at this point in the history

  4. Fix minor formatting errors

    @knutole
    knutole committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e4f261d View commit details
    Browse the repository at this point in the history