Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dml.py #208

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Update dml.py #208

merged 1 commit into from
Dec 23, 2019

Conversation

vasilismsr
Copy link
Contributor

Small bug in clipping in DML with weight trick

@vasilismsr
Update dml.py
e88d04d 
Small bug in clipping in DML with weight trick
kbattocchi
kbattocchi approved these changes Dec 23, 2019
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you think of a simple test that would be fixed by this?

@vasilismsr
Copy link
Contributor Author

LGTM. Can you think of a simple test that would be fixed by this?

One easy would be to use a classifier instead of a regressor and forget the discrete_treatment=True flag. Then many T residuals will be zero

@vasilismsr vasilismsr merged commit 61a69ea into master Dec 23, 2019
@vsyrgkanis vsyrgkanis deleted the vasilismsr-patch-1 branch November 17, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasilismsr @kbattocchi