Fix bug in marginal effect for 2SLS #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
force-pushed
the
kebatt/fix2slsMarginalEffect
branch
from
827100e
to
dc64cca
Compare
kbattocchi
commented
Feb 12, 2020
Comment on lines
-253
to
+333
| W = np.zeros((n, self._d_w)) | ||
| W = np.zeros((size(T), self._d_w)) |
There was a problem hiding this comment.
This is the only real change in this PR - the shape of W was wrong when there was more than a single treatment.
The other changes are shoring up our tests for this class and adding a DPolynomialFeatures class that can be used for dt_features when t_features is a PolynomialFeatures instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219