Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two issues #223

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix two issues #223

merged 2 commits into from
Feb 20, 2020

Conversation

kbattocchi
Copy link
Collaborator

Fixes #206, fixes #207

heimengqi
heimengqi approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kbattocchi kbattocchi merged commit c106485 into master Feb 20, 2020
@kbattocchi kbattocchi deleted the kebatt/fixFitTransform branch February 20, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimengqi heimengqi heimengqi approved these changes

@moprescu moprescu Awaiting requested review from moprescu

@vasilismsr vasilismsr Awaiting requested review from vasilismsr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in docstring of sparselineardml Fit transform in inference should be just transform
2 participants
@kbattocchi @heimengqi