-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes #248
Merged
Merged
Small fixes #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
force-pushed
the
kebatt/miscFixes
branch
3 times, most recently
from
April 17, 2020 22:32
2761a43
to
66d8c2d
Compare
kbattocchi
force-pushed
the
kebatt/miscFixes
branch
3 times, most recently
from
May 8, 2020 23:49
51763fd
to
dad8dcd
Compare
kbattocchi
force-pushed
the
kebatt/miscFixes
branch
2 times, most recently
from
June 9, 2020 01:46
dad8dcd
to
b1fec80
Compare
kbattocchi
force-pushed
the
kebatt/miscFixes
branch
2 times, most recently
from
June 15, 2020 18:03
119ca77
to
dcb96f5
Compare
kbattocchi
force-pushed
the
kebatt/miscFixes
branch
from
June 24, 2020 08:35
dcb96f5
to
aefa6e9
Compare
heimengqi
suggested changes
Aug 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed by commit, almost looks great! I left only few comments, please take a look!
kbattocchi
force-pushed
the
kebatt/miscFixes
branch
2 times, most recently
from
August 11, 2020 06:05
6ea32a4
to
d11b6d8
Compare
heimengqi
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All look good!
kbattocchi
force-pushed
the
kebatt/miscFixes
branch
from
August 11, 2020 18:03
d11b6d8
to
64ab289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244. Fixes #246. Fixes #237. Fixes #251. Fixes #263.