Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various causal analysis fixes #468

Merged
merged 8 commits into from
May 19, 2021
Merged

Various causal analysis fixes #468

merged 8 commits into from
May 19, 2021

Conversation

kbattocchi
Copy link
Collaborator

@kbattocchi kbattocchi commented May 14, 2021

Addresses various minor issues.
Fixes #467.

Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added comments on some corner cases I can think of

setup.cfg Show resolved Hide resolved
@kbattocchi kbattocchi force-pushed the kebatt/causal_analysis branch 2 times, most recently from b2f7bd7 to d3f7d9a Compare May 18, 2021 21:32
@kbattocchi kbattocchi force-pushed the kebatt/causal_analysis branch from d3f7d9a to b391eef Compare May 19, 2021 00:30
@kbattocchi kbattocchi merged commit dbbd948 into master May 19, 2021
@kbattocchi kbattocchi deleted the kebatt/causal_analysis branch May 19, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear/Incorrect Maths in documentation of OrthoLearner
2 participants