Correct default value of alphas

[mtanghu]

The PopulationSummaryResults class should to default to self.alpha when the alpha parameter is not passed. This is not the case currently since some methods use the statement 'alpha = self.alpha if alpha is None else alpha', however alpha's default value in the methods is .1, thus self.alpha will be ignored even if the client does not pass the alpha parameter.

Without the fix ate_interval(), marginal_ate_interval() and const_marginal_ate_interval() all ignore the alpha parameter.

[heimengqi]

Thanks @mtanghu ! Great catch! I will address that thoroughly in a separate PR.

[heimengqi]

@mtanghu We are happy to have more external contributors. I think your current fix have already partially addressed this issue, and we have the similar issue for value, tol and decimals as well, it would be great if you'd like to implement those changes as well.

The logic will be in the initializer we have some default alpha, value, tol, decimals since call PopulationSummaryResult will output the summary table, and if users still want to call PopulationSummaryResult.conf_int_mean() for instance, by default it will use the same alpha set from initializer, but if they call .conf_int_mean(alpha=bla), it will update the CI with new alpha. In this case, default for alpha, value, tol, decimals in each method has to be None.

[mtanghu]

@heimengqi I'd love to! I'll do that this weekend!

[kbattocchi]

Thanks, this mostly looks good, but I've added a few extra suggestions (one of which was also made by @heimengqi).

Once those are addressed I'd be happy to approve this.

[kbattocchi]

@mtanghu Are you still interested in following this through, or should someone on our team do the remaining work to get this PR cleaned up and then merged?

[mtanghu]

@kbattocchi Oh yes sorry, I'm definitely interested and just caught up in other work. I should be able to get this PR cleaned up soon!

[ghost]

All CLA requirements met.

[mtanghu]

This should be ready to merge, lmk if there's anything you else you'd like me to help with

[kbattocchi]

Looks good to me, thanks!