Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiling Unit Tests #575

Merged
merged 34 commits into from
Apr 6, 2022
Merged

Profiling Unit Tests #575

merged 34 commits into from
Apr 6, 2022

Conversation

xrowan
Copy link
Contributor

@xrowan xrowan commented Feb 17, 2022 •
edited
Loading

Causal Tests:

  • flaky due to high memory usage
  • ~400MB from importing CausalAnalysis class (as reference pandas is ~20MB)
  • test_basic_array (10MB). test_automl_first_stage (20MB), test_final_models (180MB), test_forest_with_pandas (50MB), test_random_state (230MB)

kbattocchi
kbattocchi requested changes Mar 7, 2022
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but we need to re-enable the pytest flags that make the tests show up in Azure, at least until moving everything to GitHub Actions.

econml/tests/test_driv.py Outdated Show resolved Hide resolved
econml/tests/test_driv.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
econml/tests/test_causal_analysis.py Show resolved Hide resolved
@kbattocchi kbattocchi marked this pull request as ready for review April 5, 2022 17:01
@kbattocchi kbattocchi enabled auto-merge (squash) April 5, 2022 17:04
xrowan added 25 commits April 5, 2022 14:46
@kbattocchi
removes nested for loops; reduces n to 500
fa4e28e
@kbattocchi
linting fixes
a4eb09f
@kbattocchi
reorganize imports
dc47b6a
@kbattocchi
removes unused imports
8e4682f
@kbattocchi
runs tree tests serially
2cb7f40
@kbattocchi
fixes typo
0cccf37
@kbattocchi
linting fix
684e1c7
@kbattocchi
reorganize imports
0b951fd
@kbattocchi
run test serially
d1068c0
@kbattocchi
adds tags for cate_api tests
33c580f
@kbattocchi
sets up new test marks in azure pipelin
caba5ce
@kbattocchi
fixes typo in pipeline yml
a588897
@kbattocchi
debug pipeline
0da6860
@kbattocchi
reorganize imports
fd5b3e2
@kbattocchi
adds back dependency
ae7086b
@kbattocchi
remove unused imports
57afa35
@kbattocchi
reduce size of matrix by half
64c0c7f
@kbattocchi
reverts n
3d7340d
@kbattocchi
moves test_statsmodels to serial testing
194743e
@kbattocchi
combines other tests to single job
ac28cf0
@kbattocchi
removes nested loops from test_random_state
2ac1aa6
@kbattocchi
fixes indenting
78c0391
@kbattocchi
tries running causal tests in parallel
b6b6f49
@kbattocchi
remove unnecessary deps
b36a2cb
@kbattocchi
linting fix
1ea012b
@kbattocchi kbattocchi merged commit 3228508 into main Apr 6, 2022
@kbattocchi kbattocchi deleted the xrowan/test_profiling branch April 6, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrowan @kbattocchi