Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _preprocess_data to align with sklearn refactor #638

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

fverac
Copy link
Collaborator

@fverac fverac commented Jun 21, 2022

Making changes to some preprocessing in our sklearn extensions to align with sklearn refactoring. These are necessary changes to align with sklearn 1.1+.

Relevant sklearn changes here: scikit-learn/scikit-learn#22762

@fverac fverac requested a review from kbattocchi June 21, 2022 17:13
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. One minor but important suggestion.

setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
@kbattocchi kbattocchi linked an issue Jun 21, 2022 that may be closed by this pull request
@fverac fverac merged commit b95f594 into main Jun 22, 2022
@fverac fverac deleted the fverac/preprocess_data_fix branch June 22, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sklearn 1.1
2 participants