Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some pipeline images (macos-12, ubuntu20), fix pycodestyle E275 #672

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

fverac
Copy link
Collaborator

@fverac fverac commented Sep 14, 2022

macos-10.15 will soon be deprecated in GitHub Actions and Azure Devops so we are upgrading the version of macOS that we use.

Relevant issue:

actions/runner-images#5583

Additionally updating the deprecated ubuntu 18 image to ubuntu 20.

Fixing multiple new E275 style errors with new pycodestyle update.

Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Consider adding a comment to the PR description indicating that the spacing changes are due to a pycodestyle update in case we ever need to go back through the history of those lines.

@fverac fverac changed the title update some pipeline steps to macos-12 update some pipeline images (macos-12, ubuntu20), fix pycodestyle E275 Sep 14, 2022
@fverac fverac merged commit dff978e into main Sep 14, 2022
@fverac fverac deleted the fverac/update_macos_builds branch September 14, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants