CATE uplift validation methods #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
requested changes
Jan 3, 2024
|
Thank you for your comments, I have updated the code and test cases to address them. The PR now reflects the updated version. Test case coverage is still 100%. 
Let me know if you have any further comments. |
kbattocchi
approved these changes
Jan 10, 2024
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
amarvenu
force-pushed
the
dr_val_uplift
branch
from
88981b6
to
078630a
Compare
|
I’ve amended the commits accordingly, so the branch should be ready to merge now. Thanks! |
kbattocchi
pushed a commit
to kbattocchi/EconML
that referenced
this pull request
Jan 23, 2024
Added additional functionality to the DRTester validation class to include AUTOC validation metric, with associated inference methods. Also included ability to plot uplift curve methods (both QINI and TOC curves) and cleaned up handling of multiple treatments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional functionality to the DRTester validation class to include AUTOC validation metric, with associated inference methods. Also included ability to plot uplift curve methods (both QINI and TOC curves) and cleaned up handling of multiple treatments.
Modified files are:
Test cases were extended to include the modifications, maintaining 100% coverage:
Looking forward to any comments.