-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CATE validation - uplift uniform confidence bands #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks great, added a few minor suggestions.
kbattocchi
approved these changes
Mar 18, 2024
…rs for uplift curves Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
…ling Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com> Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com> Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com> Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com> Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional functionality to the DRTester validation class to include uniform confidence bands (both two- and one-sided) for uplift curve plots, calculated via the multiplier bootstrap.
Modified files are:
Test cases were extended to include the modifications, maintaining 100% coverage:
Looking forward to any comments.