Minor fixes #891
Merged
Minor fixes #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
kbattocchi
force-pushed
the
kebatt/minorFixes
branch
2 times, most recently
from
fd2c545
to
fb16c66
Compare
fverac
reviewed
Jun 28, 2024
| @@ -321,8 +321,8 @@ def test_non_standard_input(self,): | |||
| model_propensity=DummyClassifier(strategy='uniform'), | |||
| featurizer=PolynomialFeatures(degree=1, include_bias=False), | |||
| cv=GroupKFold(n_splits=2), | |||
| n_estimators=20, n_jobs=1, random_state=123).fit(y, T, X=X, | |||
| groups=groups) | |||
| n_estimators=100, n_jobs=1, random_state=123).fit(y, T, X=X, | |||
There was a problem hiding this comment.
Is this for test stability?
There was a problem hiding this comment.
Because n_estimators was never passed correctly to DRPolicyForest in the past, this has always effectively run with n_estimators=100 (the default value), and the tests don't pass if we actually pass 20 through instead.
kbattocchi
force-pushed
the
kebatt/minorFixes
branch
from
fb16c66
to
acb202a
Compare
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
kbattocchi
force-pushed
the
kebatt/minorFixes
branch
from
acb202a
to
3dff057
Compare
|
this looks great, thank you - when can a new version be released to pypi so we can depend on it? |
|
just a gentle ping on the ETA for this fix, as we need it to resolve a security vulnerability in scikit-learn |
We hope to put out a bugfix release containing these fixes by the end of this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.