Adding causal prediction code using CACM with demo notebook #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jivatneet <jivatneet@gmail.com>
Signed-off-by: jivatneet <jivatneet@gmail.com>
jivatneet
force-pushed
the
causal_pred
branch
from
8a7a81a to
d11c5c0
Compare
amit-sharma
requested changes
Nov 2, 2022
There was a problem hiding this comment.
Great start for the prediction functionality @jivatneet I have added inline comments. Main feedback is on adding documentation: both in the notebook and inline docstrings.
docs/source/example_notebooks/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
docs/source/example_notebooks/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
docs/source/example_notebooks/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
docs/source/example_notebooks/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
docs/source/example_notebooks/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by: jivatneet <jivatneet@gmail.com>
amit-sharma
reviewed
Nov 22, 2022
There was a problem hiding this comment.
Thanks for these edits, @jivatneet. It's very close to a first merge! I've added a few comments.
Let me also tag Emre as a reviewer.
docs/source/example_notebooks/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
docs/source/example_notebooks/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by: jivatneet <jivatneet@gmail.com>
amit-sharma
reviewed
Nov 23, 2022
Signed-off-by: jivatneet <jivatneet@gmail.com>
Signed-off-by: jivatneet <jivatneet@gmail.com>
amit-sharma
previously approved these changes
Dec 9, 2022
Signed-off-by: jivatneet <jivatneet@gmail.com>
Signed-off-by: jivatneet <jivatneet@gmail.com>
Signed-off-by: jivatneet <jivatneet@gmail.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
amit-sharma
approved these changes
Dec 22, 2022
Padarn
pushed a commit
to Padarn/dowhy
that referenced
this pull request
Jan 31, 2023
… notebook (py-why#729) * add causal prediction using cacm + demo notebook Signed-off-by: jivatneet <jivatneet@gmail.com> * Adding causal prediction code using CACM with demo notebook Signed-off-by: jivatneet <jivatneet@gmail.com> * addressing comments: fixing documentation in base_algorithm and cacm Signed-off-by: jivatneet <jivatneet@gmail.com> * addressing comments: fixing documentation in base_dataset Signed-off-by: jivatneet <jivatneet@gmail.com> * rename Algorithm class Signed-off-by: jivatneet <jivatneet@gmail.com> * updating base_dataset for format check Signed-off-by: jivatneet <jivatneet@gmail.com> * adding exception for optimizer; resolving list bug Signed-off-by: jivatneet <jivatneet@gmail.com> * adding docs for base algo Signed-off-by: jivatneet <jivatneet@gmail.com> * added torch to dev dependency * added torchlightning to dev dependency Signed-off-by: Amit Sharma <amit_sharma@live.com> * updated poetry.lock Signed-off-by: Amit Sharma <amit_sharma@live.com> * updated gpu to devices Signed-off-by: Amit Sharma <amit_sharma@live.com> Signed-off-by: jivatneet <jivatneet@gmail.com> Signed-off-by: Amit Sharma <amit_sharma@live.com> Co-authored-by: Amit Sharma <amit_sharma@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding causal prediction API code and demo using Causally Adaptive Constraint Minimization (CACM).
I was facing issues in ensuring torch compatibility with poetry. Mentioning the exact dependencies here: