-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add ability to draw graphs with a title #71
Conversation
Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a unit-test and also add a changelog entry to docs/whats_new/v0.1.rst
?
Sure! Just getting used to the procedure for this repo. |
Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It mostly looks good minus a few nitpicks.
One last thing: Can you also augment the existing example in examples/
to show off the label feature? E.g. in https://output.circle-artifacts.com/output/job/e94330e9-bd6c-4d83-ae14-8ed903121326/artifacts/0/dev/auto_examples/visualization/draw_and_compare_graphs_with_same_layout.html#sphx-glr-auto-examples-visualization-draw-and-compare-graphs-with-same-layout-py it would be great to see some sensible titles of the different graphs.
You can build the documentation locally to test it out and what it looks like by following the Contributing.md doc. Lmk if you have any issues! You'll also want to fix the coding style using the relevant poetry run poe apply_format
command as well (which runs black and isort in the background)
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 84.03% 84.42% +0.38%
==========================================
Files 29 34 +5
Lines 2255 2555 +300
Branches 578 687 +109
==========================================
+ Hits 1895 2157 +262
+ Misses 254 251 -3
- Partials 106 147 +41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Adam Li <adam2392@gmail.com> Signed-off-by: Aryan Roy <50577809+aryan26roy@users.noreply.github.com>
Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
Hey @adam2392 I think I implemented all the changes you requested. Sorry for the delay though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI passes
Thanks @aryan26roy ! |
Closes #23
Changes proposed in this pull request:
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting