Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTS-ONLY] Fix Flaky GatewayServerTest #543

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[TESTS-ONLY] Fix Flaky GatewayServerTest #543

merged 2 commits into from
Apr 16, 2024

Conversation

ahirreddy
Copy link
Contributor

  • This PR fixes the GatewayServerTest to handle a race condition in the GatewayServer's handling of connections with invalid secrets.
  • The server may either return an appropriate error message (this is what the test expected pre-patch) or the server may return no response (which becomes a null response)
  • The test-case is updated to accept both responses as valid

@ahirreddy
[TESTS-ONLY] Fix Flaky GatewayServerTest
397a46b 
- This PR fixes the GatewayServerTest to handle a race condition in the GatewayServer's handling of connections with invalid secrets.
- The server may either return an appropriate error message (this is what the test expected pre-patch) or the server may return no response (which becomes a `null` response)
- The test-case is updated to accept both responses as valid
@ahirreddy
fix style
c34dc6e
@HyukjinKwon
Copy link
Member

Merged, thx.

@HyukjinKwon HyukjinKwon merged commit 2285767 into py4j:master Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahirreddy @HyukjinKwon