Run fftw tests #11
Open
Run fftw tests #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancan101
force-pushed
the
cancan101-patch-4
branch
from
e493efe
to
285504f
Compare
|
@matthew-brett Should I add these tests to the formula or is that overkill? It does make the build take longer. |
|
Does the build fail if the tests fail? Do the Python tests not test the same functionality? |
|
The python test is pretty rudimentary. Makes sure that import works and that no Mkl issue. The fftw tests are supplied by fftw and do some numerical testing. |
|
Then - more testing is better :) - but does the build fail if the tests fail? |
|
I need to verify but I think with the set e |
cancan101
force-pushed
the
cancan101-patch-4
branch
from
b53515a
to
e879a3d
Compare
|
@matthew-brett I don't get why these tests are passing. I don't even see the building messages in the logs yet CI is passing. |
|
@matthew-brett I think the return value of |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of: #12