-
Notifications
You must be signed in to change notification settings - Fork 72
Fixed hover background color issue #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I just realized that in the dark mode, the hover text looks a little bit hard to read, so I might edit that as well so that it is consistent across both light and dark modes. |
…with hoverlabel_bgcolor keyword argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses the hover background color issue in the Translation Guide’s interactive graph by explicitly setting hover label styling.
- Added
hoverlabel_bgcolor
to ensure hover labels have a visible background. - Added
hoverlabel_font_color
to guarantee hover text is readable. - Verified that no docs tests were broken by running
nox docs-test
.
Removed extra white space. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Used CSS variable instead of hardcoded "white" value. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@all-contributors please add @hfactor13 for code, review |
I've put up a pull request to add @hfactor13! 🎉 |
It was meant to address the font issue for both light and dark modes, but there's some conflicts still.
I noticed that when I rebuilt the website, my light mode changes didn't show up. I rechecked the CSS variable |
I am at keyboard again and can help with this, but the PR looks empty to me? |
@hfactor13 i think something broke about this PR because i'm not seeing a diff, but i made a version over here: #556 sorry for the confusion. as far as i'm aware there is no way to use css vars in the plotly color declarations in some places, and these happen to be some of those places. |
@sneakers-the-rat I see what you mean. Yes, it's weird that the diff didn't show in this PR. I saw your linked PR. I was planning to go in that direction where I would change the CSS directly, but I didn't know the name of the CSS tag. It's a bummer that I can't just change these properties from Plotly directly, but hey, at least I learned something new. |
@hfactor13 thank you for all of the effort during the sprints!! I am going to close this PR as it's empty but I did add you as a contributor to this repo so you will get that credit for your effort!! |
@lwasser Okay. Sounds good. I appreciate it. Thank you! |
thank you for all of your work at SciPy @hfactor13 !! it was awesome to see you again and I'm glad you're in our slack now as well!! |
I fixed the hover background issue for the Translation Guide for the Python Packaging Guide (Issue #532). I also ran the
nox docs-test
command, and everything came back successful. Feel free to let me know if there's anything else I should include with this pull request.