Skip to content

fix: typos #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2023
Merged

fix: typos #85

merged 2 commits into from
Jun 13, 2023

Conversation

dpprdan
Copy link
Contributor

@dpprdan dpprdan commented May 31, 2023

This fixes (what I believe to be) two typos.

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these edits! i'm going to let ci run and then will merge this!!

@lwasser
Copy link
Member

lwasser commented Jun 13, 2023

@all-contributors please add @dpprdan for code, review

@allcontributors
Copy link
Contributor

@lwasser

I've put up a pull request to add @dpprdan! 🎉

@lwasser
Copy link
Member

lwasser commented Jun 13, 2023

wonderful - all checks passed! merging this now. @dpprdan may i ask - how did you find us here??

@lwasser lwasser merged commit 8e8de62 into pyOpenSci:main Jun 13, 2023
@dpprdan dpprdan deleted the patch-1 branch June 13, 2023 07:35
@dpprdan
Copy link
Contributor Author

dpprdan commented Jun 13, 2023

@lwasser I think it was something like (ropensci?!) -> your mastodon account -> the demystifying python packaging blog post -> Python Package Guide.

I am dabbling with python packaging ATM and took the Poetry (also via https://py-pkgs.org/) route for now. Looking forward to more content in the Python Package Guide 😄

@lwasser
Copy link
Member

lwasser commented Jun 13, 2023

awesome!! well thank you so much for the edits - it's much appreciated!! poetry is a great tool.and that guide is a great one as well! a lot of people really like it and poetry!! just be careful with the upper bounds element in your package :) you can just remove that constraint and still take full advantage of poetry's many features!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants