Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update scope document and also fix a few sphinx bugs #162

Merged
merged 32 commits into from
Feb 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
ba272d9
Fix: update package scope page with more specifics and examples
lwasser Jan 31, 2023
b839139
Fix: pydata theme header bug fixed
lwasser Jan 31, 2023
f70c92f
Fix: more cleanup of links throughout
lwasser Jan 31, 2023
eb5733b
Fix: EIC template button link incorrect
lwasser Feb 1, 2023
e2c0066
Update about/package-scope.md
lwasser Feb 1, 2023
c3ec5c6
Update about/package-scope.md
lwasser Feb 1, 2023
59c2bd5
Update about/package-scope.md
lwasser Feb 1, 2023
35bfc62
Update about/package-scope.md
lwasser Feb 14, 2023
f2b3c9d
Update about/package-scope.md
lwasser Feb 14, 2023
07d219c
Update about/package-scope.md
lwasser Feb 14, 2023
1248d93
Update about/package-scope.md
lwasser Feb 14, 2023
bbcf516
Update about/package-scope.md
lwasser Feb 14, 2023
c78faac
Update about/package-scope.md
lwasser Feb 14, 2023
e80bc22
Update about/package-scope.md
lwasser Feb 14, 2023
57ccb6e
Update about/package-scope.md
lwasser Feb 14, 2023
272d5ba
Fix: scope categories update
lwasser Feb 14, 2023
665bfe1
Fix: update typos and add review feedback
lwasser Feb 14, 2023
3d7a6f8
Fix: working of telemetry clause
lwasser Feb 14, 2023
4c5a12e
Fix: missed a conflict
lwasser Feb 14, 2023
75dd711
Merge branch 'main' into update-scope
lwasser Feb 14, 2023
c9c90c2
Update about/package-scope.md
lwasser Feb 14, 2023
1fb11a6
Apply suggestions from code review
lwasser Feb 14, 2023
4fe7f02
Update about/package-scope.md
lwasser Feb 14, 2023
cc7e9ce
Update about/package-scope.md
lwasser Feb 14, 2023
31f4a03
Fix: a few broken links
lwasser Feb 14, 2023
06ada72
Update about/package-scope.md
lwasser Feb 21, 2023
2eef270
Update about/package-scope.md
lwasser Feb 21, 2023
9efc539
Update about/package-scope.md
lwasser Feb 21, 2023
6de8c52
Apply suggestions from code review
lwasser Feb 21, 2023
46570dd
Fix: small changes from review
lwasser Feb 21, 2023
152c2f3
Fix: more reviewer feedback integrated
lwasser Feb 21, 2023
f5b50d9
Remove telemetry statement for now
lwasser Feb 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes
2 changes: 1 addition & 1 deletion about/intro.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Why Open Review Matters </about/why-open-review>
How Review Works <../our-process/how-review-works>
Review Timeline <../our-process/review-timeline>
Peer Review Policies <../our-process/policies>

Code of Conduct <../code-of-conduct>
```


Expand Down
235 changes: 230 additions & 5 deletions about/package-scope.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,246 @@ Currently, the packages that pyOpenSci reviews also need to fall into the
technical and applied scope of our organization. This scope may expand over time
as the organization grows.



## Is Your Package in Scope For pyOpenSci Review?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriknw @NickleDave @arianesasso @cmarmo @sneakers-the-rat @Batalex i'd LOVE your input on these changes. this page is really the only one you have to look at in this review. the rest of the changes are just link fixes and cleanup.

Many thanks in advance for this!


pyOpenSci only reviews packages that fall within our specified domain and
technical scope listed below.
pyOpenSci reviews packages that fall within a list of specified categories and
domains. Packages must also meet our technical scope requirements.

If you are unsure whether your package is in scope for review, please
open a [pre-submission inquiry using a GitHub Issue](https://github.com/pyOpenSci/software-review/issues/new?assignees=&labels=0%2Fpresubmission&template=presubmission-inquiry.md&title=) to get feedback from
one of our editors. We are happy to look at your package and help you understand
whether it is in scope or not.

```{include} /appendices/scope.md
### About the types of packages that we review

pyOpenSci reviews packages that support open reproducible science,
data processing and and the various stages of managing the
lwasser marked this conversation as resolved.
Show resolved Hide resolved
data lifecycle. Packages submitted to pyOpenSci should fit into one or
more of the categories below and should be within our technical scope.

```{admonition} Your Package Does Not Need to Have Widespread Use to be Reviewed
:class: important

We review packages with the goal of improving package quality and usability for scientists.
As such, we review packages across a spectrum of small to large user bases. The popularity of your package is not a consideration in our review process!

When we evaluate whether you package is within our scope, we only consider:

1. how the package is developed and
2. how the package relates to and supports the broader scientific ecosystem.

We welcome young packages that are just entering the scientific Python
ecosystem to apply for review if they are relevant to the science community and
fit into at least one scope category below. We also welcome mature packages with
a growing or established community!
```

If you are unsure whether your package fits into one of the general or
statistical categories, please open an issue as a [pre-submission inquiry](https://github.com/pyOpenSci/software-submission/issues/new?assignees=&labels=0%2Fpresubmission&template=presubmission-inquiry.md&title=).

```{note}
This is a living document. The categories below may change through time.
This may mean in some cases, some previously peer review-accepted packages
may not be in-scope today. We strive for consistency in our peer review process. However, we also evaluate packages on a case-by-case basis.
In some cases exceptions are made.
```

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: i think we should add a policy around telemetry in packages. a current review has it. i think we should discourage against it but if it's required make it opt in rather than opt out preferred?

We should also evaluate whether we want to review general data manipulation and coding tools. ROS does not review these tools. but defining what that means is tricky.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps start with a narrower scope? It's easy to broaden it later, but not the other way around.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! is this a specific comment related to our scope as defined now or just to that statement above? I added that given Ropensci has similar language and it just allows us to adjust in the future in case we realize we are headed down a rabbit hole that doesn't work for us! (kind of like a legal disclaimer :) in case we need to modify scope)

We've had the same scope for the past 4 years BUT of course we are being more specific now about each category given all of the questions we've gotten :)

## Package categories

The following are the current categories that fall into scope for
pyOpenSci. In addition to fitting into one or more of these categories, your package should have some level of
demonstrated scientific application. This could be a use case that you can
link to or a tutorial that demonstrates its potential application for science.

Below we provide examples of packages from pyOpenSci ecosystem. Because we
have growing community of packages, in some cases we link to R packages
within the rOpenSci community that match the category scope for reference.

We will update this page as our review process evolves.

```{note}
Many of the example packages below perform tasks that might fit in multiple
categories. There examples are there to provide you with a flavor of the types
of packages that would fall into that category.
```

### Data retrieval
Packages for accessing and downloading data from online sources. This category
includes wrappers for accessing APIs.

Our definition of scientific applications is broad, including data storage
services, journals, and other remote servers, as many data sources may be of
interest to scientists. However, retrieval packages should be focused on data
sources / topics, rather than services. For example a general client for Amazon
Web Services data storage would not be in-scope.

* Examples: [OpenOmics](https://github.com/pyOpenSci/software-submission/issues/31), [pyDov](https://github.com/pyOpenSci/software-submission/issues/19), [Physcraper](https://github.com/pyOpenSci/software-review/issues/26)

lwasser marked this conversation as resolved.
Show resolved Hide resolved

### Data extraction

These packages aid in retrieving data from unstructured sources such as text,
images, and PDFs. They might also parse scientific data types and outputs from
scientific equipment.

* Examples: [devicely](https://github.com/pyOpenSci/software-submission/issues/37), [jointly](https://github.com/pyOpenSci/software-submission/issues/45)

### Data processing & munging

Data [munging tools transform data in a way that makes further analysis possible (as [defined on Wikipedia](https://en.wikipedia.org/wiki/Data_wrangling)). Munging complements the other categories so it's common for packages to include some functionality to munge data. This
category focuses on tools for handling data in specific formats that scientists
may be interested in working with. These data may also be generated from
scientific workflows or exported from instruments and wearables.

* Examples: [devicely](https://github.com/pyOpenSci/software-submission/issues/37), [jointly](https://github.com/pyOpenSci/software-submission/issues/45), [MovingPandas](https://github.com/pyOpenSci/software-submission/issues/18), [OpenOmics](https://github.com/pyOpenSci/software-submission/issues/31), [Physcraper](https://github.com/pyOpenSci/software-submission/issues/26)


### Data deposition

Tools for depositing data into scientific research repositories.

* Examples: [This is an example from rOpenSci - eml](https://github.com/ropensci/software-review/issues/80)

### Data validation and testing:

Tools that enable automated validation and checking of data quality and
completeness. These tools should be able to support scientific workflows.

* Example: [pandera](https://github.com/pyOpenSci/software-submission/issues/12)

### Scientific software wrappers

Scientific software wrappers refer to packages that provide a Python interface
for existing scientific packages written in other languages.

These packages should have a clear scientific application. Wrappers must provide
significant added value to the scientific ecosystem be it in data handling, or
improved installation processes for Python users.

We strongly encourage submissions that wrap tools that are open-source with
an OSI-approved license. Exceptions will be evaluated case-by-case,
considering whether open-source options exist.

* Examples: [PyGMT](https://github.com/pyOpenSci/software-submission/issues/43)

### Workflow automation & versioning
Tools that automate and link together workflows and as such support
reproducible workflows. These
tools may include build systems and tools to manage continuous integration.
This also includes tools that support version control.

* Examples: Both of these tools are not pyOpenSci reviewed as of yet but are examples of tools that might be in scope for this category - [snakemake](https://snakemake.readthedocs.io/en/stable/), [pyGitHub ](https://github.com/PyGithub/PyGithub)

### Citation management and bibliometrics:

Tools that facilitate managing references, such as for writing manuscripts,
creating CVs or otherwise attributing scientific contributions, or accessing,
manipulating or otherwise working with bibliometric data. (Example: [Example from rOpenSci - RefManageR](https://github.com/ropensci/software-review/issues/119))

### Data visualization & analysis
These are packages that enhance a scientists experience visualizing and
analyzing data.

* Examples: [PyGMT - (also spatial and data munging)](https://github.com/pyOpenSci/software-submission/issues/43),

### Database software bindings
lwasser marked this conversation as resolved.
Show resolved Hide resolved

Bindings and wrappers for database APIs.

* Example: [Example from rOpenSci - rrlite](https://github.com/ropensci/software-review/issues/6)


## Domain areas

In addition, our scope includes focused domain areas. These areas are based on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "computational library" class, described here, seems to be missing from the previous section, when it's arguably the first category included?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say a little bit more about what you mean?
I think you're suggesting that there should be another category above that's like "general library or framework for a domain or research area"?
E.g. python-graphblas would be such a library (in addition to being a wrapper)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh... i missed a few comments here! i will make sure these are added in a separate PR. i am not sure how i missed this

partnerships that we form with communities and also expertise that we hold
within our organization. As we develop [new community partnerships](/partners/scientific-communities) and grow,
we will expand this list.

### Geospatial

Packages focused on the retrieval, manipulation, and analysis of spatial data.

* Examples: [PyGmt](https://github.com/pyOpenSci/software-submission/issues/43),
[Moving Pandas ](https://github.com/pyOpenSci/software-submission/issues/18)

### Pangeo

We have a [partnership with Pangeo](../partners/pangeo). Often times packages submitted as a part of that partnership are also in the geospatial domain.

* Examples: [xclim - under review now](https://github.com/pyOpenSci/software-submission/issues/73)

### Education

Packages to aid with instruction.

* Examples: [pyrolite](https://github.com/morganjwilliams/pyrolite)

## Package technical scope

To be in technical scope for a pyOpenSci review, your package:

* Should have maintenance workflows documented.
* Should declare vendor dependencies using standard approaches rather than including code from other packages within your repository.
* Should not have an exceedingly complex structure. Others should be able to contribute and/or take over maintenance if needed.

```{admonition} pyOpenSci's goal is to support long(er) term maintenance
pyOpenSci has a goal of supporting long term maintenance of open source
Python tools. It is thus important for us to know that if you need to step down as a maintainer, the package infrastructure and documentation is
in place to support us finding a new maintainer who can take over you
package's maintenance.
```

### What if my package seems like its category or domain is out of scope?
- pyOpenSci is still developing as a community. If your scientific Python
package does not fit into one of the categories or if you have any other
questions, we'd encourage you to open a pre-submission inquiry. We're happy to help.
- Data visualization packages come in many varieties, ranging from small
hyper-specific methods for one type of data to general, do-it-all packages
(e.g. matplotlib). pyOpenSci accepts packages that are somewhere in between the
two. If you're interested in submitting your data visualization package, please
open a pre-submission inquiry first.
lwasser marked this conversation as resolved.
Show resolved Hide resolved

## Examples of packages that might be out of technical scope

pyOpenSci may continue to update its criteria for technical scope
review as more packages with varying structural approaches are reviewed.
Your package **may not be in technical scope** for us to review at this time if
fits any of the out-of-technical-scope criteria listed below.
lwasser marked this conversation as resolved.
Show resolved Hide resolved

Your package is in technical scope if it is:
* Pure Python or Python with built extensions
* Available from PyPI and/or community conda channels such as conda-forge or bioconda

Your package might be out of in technical scope if it is:
* Not published in a community channel such as PyPI or a channel on anaconda cloud
* Exceedingly complex in its structure or maintenance needs

A few examples of packages that may be too technically challenging for us to
find a new maintainer for in the future are below.

### Example 1: Your package is an out of sync fork of another package repository that is being actively maintained.

Sometimes we understand that a package maintainer may need to step down. In
that case, we strongly suggest that the original package owner, transfer the
package repository to a new organization along with PyPI credentials. A new
organization would allow transfer of ownership of package maintenance rather
than several forks existing.

If your package is a divergent fork of a maintained repository we will encourage you
to work with the original maintainers to merge efforts.

However, if there is a case where a forked repository is warranted, please
consider submitting a pre-submission inquiry first and explain why the package is a
fork rather than an independent parent repository.

### Example 2: Vendored dependencies

If your package is a wrapper that wraps around another tool, we prefer that
the dependency be added as a dependency to your package. This allows
maintenance of the original code base to be independent from your package's
maintenance.

(package-overlap)=
## Package Overlap
pyOpenSci encourages competition among packages, forking and re-implementation
Expand Down
2 changes: 1 addition & 1 deletion appendices/glossary.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ definitions for reference.
* **docstring**: A miniature piece of documentation within the source code, usually documenting a specific function, class, or other piece of code.
* **linting/linter**: A linter is a program that you can run on your code to identify potential errors. There are many linters for Python, e.g. flake8.
* **module**: A file containing Python code. Modules can define functions, classes, and more, and can be imported by other Python code to use those defined objects. Some files are meant to be run directly instead of imported. These are "scripts".
* **open source**: In simple terms, software for which the source code is freely available and can be modified and redistributed. What meets the standard of "open source" can be controversial, but the Open Source Initiative has a more thorough set of [guidelines](https://opensource.org/osd-annotated).
* **open source**: In simple terms, software for which the source code is freely available and can be modified and redistributed. What meets the standard of "open source" can be controversial, but the Open Source Initiative has a more thorough set of [guidelines](https://opensource.org/definition/).
* **slug**: A short title, containing only letters, numbers, underscores, and hyphens. For example, a slug might replace spaces with underscores. Your package's "slug" is a handy shorthand.
* **software license**: Contains the terms of use, modification, and distribution for a piece of software. Open source licenses generally grant freedom to modify and share software, but sometimes there are specific conditions. Read more from [OSI](https://opensource.org/licenses).
* **testing**: Code tests check units of code to make sure that they are producing the expected result. For example, if you have a function "sum_nums" that sums numbers, you could write a test that makes sure that sum_nums(2, 2) == 4. Writing full tests helps to avoid bugs as you are writing or modifying your code.
Expand Down
74 changes: 0 additions & 74 deletions appendices/scope.md

This file was deleted.

8 changes: 5 additions & 3 deletions code-of-conduct.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Community Code of Conduct
# pyOpenSci Code of Conduct

We keep our Code of Conduct in our governance documentation. [Click here to
go there now.](https://www.pyopensci.org/governance/CODE_OF_CONDUCT.html)
All individuals participating in any pyOpenSci program such as our peer review process, need to abide by our code of conduct.

[Click here to
read our full code of conduct now.](https://www.pyopensci.org/governance/CODE_OF_CONDUCT.html)
Loading