Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope link #204

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Fix scope link #204

merged 2 commits into from
Mar 28, 2023

Conversation

astrojuanlu
Copy link
Contributor

@astrojuanlu astrojuanlu commented Mar 27, 2023 •
edited
Loading

Closes gh-150

(Didn't test this locally 🤞🏽)

@astrojuanlu
Copy link
Contributor Author

Now it seems to work: https://output.circle-artifacts.com/output/job/44005f92-37a6-4757-96a5-31c74d82b5cb/artifacts/0/html/how-to/author-guide.html#is-your-package-in-scope-for-pyopensci

@NickleDave NickleDave requested a review from lwasser March 27, 2023 20:53
@NickleDave
Copy link
Contributor

🙌 you beat me to the PR! Thank you @astrojuanlu!

@lwasser
Copy link
Member

lwasser commented Mar 28, 2023

thank you so much for this @astrojuanlu

@lwasser
Copy link
Member

lwasser commented Mar 28, 2023

@all-contributors please add @astrojuanlu for code, review

@allcontributors allcontributors bot mentioned this pull request Mar 28, 2023
Merged
@allcontributors
Copy link
Contributor

@lwasser

I've put up a pull request to add @astrojuanlu! 🎉

@lwasser lwasser merged commit 85819ac into pyOpenSci:main Mar 28, 2023
@astrojuanlu astrojuanlu deleted the patch-1 branch March 28, 2023 06:45
@astrojuanlu astrojuanlu mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwasser lwasser Awaiting requested review from lwasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MOVE https://www.pyopensci.org/peer-review-guide/software-peer-review-guide/reviewer-guide.html
3 participants
@astrojuanlu @NickleDave @lwasser