Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update scope criteria for analytics packages #283

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Mar 28, 2024

This pr updates our scope statement found in the peer review guide to specifically address analytics related packages. It is now open for community review!


about/package-scope.md Outdated Show resolved Hide resolved
Copy link
Contributor

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, but overall I think this hits the notes we need it to in order to clarify scope around analytic packages 🙌

about/package-scope.md Outdated Show resolved Hide resolved
about/package-scope.md Outdated Show resolved Hide resolved
lwasser and others added 2 commits April 3, 2024 11:22
Co-authored-by: Isabel Zimmerman <54685329+isabelizimm@users.noreply.github.com>
@lwasser
Copy link
Member Author

lwasser commented Apr 3, 2024

@isabelizimm thank you so much for the review! 🙌 i've incorporated your suggestions and am going to merge this now!!

@lwasser lwasser removed the request for review from NickleDave April 3, 2024 17:24
@lwasser lwasser merged commit 4b0f79c into pyOpenSci:main Apr 3, 2024
4 checks passed
@lwasser lwasser deleted the update-scope branch April 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants