Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix l2 parameter in SAL verification #324

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Conversation

EsmailGhaemi
Copy link
Contributor

@EsmailGhaemi EsmailGhaemi commented Mar 16, 2023

Remove the multiplication factor in l2 parameter, closes #321

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1c90e44) 83.34% compared to head (49d24c3) 83.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files         161      161           
  Lines       12359    12359           
=======================================
  Hits        10301    10301           
  Misses       2058     2058           
Flag Coverage Δ
unit_tests 83.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/verification/salscores.py 90.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dnerini dnerini changed the title Fix l2 parameter #321 Fix l2 parameter in SAL verification Mar 16, 2023
@dnerini dnerini self-requested a review March 16, 2023 20:06
@dnerini dnerini merged commit 18d87c8 into pySTEPS:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

location parameter L2 in the SAL verification
2 participants