Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dataclass_transform to maintain IDE typing support for EventedModel.__init__ #154

Merged
merged 9 commits into from
Dec 20, 2022

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Dec 20, 2022

makes it so that:

class M(EventedModel):
    x: int

shows a proper signature in VScode

Screen Shot 2022-12-20 at 3 19 20 PM

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (aa734af) compared to base (4ee2a38).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1418      1422    +4     
=========================================
+ Hits          1418      1422    +4     
Impacted Files Coverage Δ
src/psygnal/_evented_model.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 enabled auto-merge (squash) December 20, 2022 20:20
@tlambert03 tlambert03 merged commit 2ed285a into pyapp-kit:main Dec 20, 2022
@tlambert03 tlambert03 deleted the add-dataclass-transform branch December 20, 2022 20:20
@tlambert03 tlambert03 added the bug Something isn't working label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

1 participant