Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2498 try different entry points method #2500

Merged
merged 4 commits into from
Nov 30, 2022

Conversation

valentinsulzer
Copy link
Member

Description

Fixes #2498
See click-contrib/click-plugins#31 (comment)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 99.72% // Head: 99.72% // No change to project coverage 👍

Coverage data is based on head (8a22af2) compared to base (53cf744).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8a22af2 differs from pull request most recent head c65c76a. Consider uploading reports for the commit c65c76a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2500   +/-   ##
========================================
  Coverage    99.72%   99.72%           
========================================
  Files          268      268           
  Lines        19285    19285           
========================================
  Hits         19232    19232           
  Misses          53       53           
Impacted Files Coverage Δ
pybamm/parameters/parameter_sets.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@awadell1
Copy link
Contributor

How are test passing when this doesn’t add entrypoints as a dependency?

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be added to the CHANGELOG? (given that a user caught this)

@valentinsulzer
Copy link
Member Author

@awadell1 I guess it must be included in default python?

@valentinsulzer valentinsulzer merged commit 8d042b3 into develop Nov 30, 2022
@valentinsulzer valentinsulzer deleted the issue-2498-entry-points branch November 30, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ContextualVersionConflict jupyter-client
4 participants