-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scheduled tests #3091
Fix scheduled tests #3091
Conversation
@agriyakhetarpal macOS tests are also failing randomly, I suggest we also try to fix those in this PR only |
I don't think they are failing on our end |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #3091 +/- ##
========================================
Coverage 99.71% 99.71%
========================================
Files 248 248
Lines 18749 18749
========================================
Hits 18695 18695
Misses 54 54 ☔ View full report in Codecov by Sentry. |
The mac tests are failing randomly due to some Github issue. It has been solved, but it is being rolled out so still randomly fails (if I understood correctly). I think it is safe to merge. More info: Homebrew/homebrew-core#135315 |
Looks good to me, but didn't quite understand why pandoc is needed. |
It is needed for converting the notebooks when building the docs (spatialaudio/nbsphinx#36) |
I missed the discussion on this PR in the meet. Is this ready for merging? |
We missed discussing this one apparently, should be ready to go |
Description
A quick fix to quick the failing doctests step in the scheduled nightly tests, after #3043
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
$ python run-tests.py --doctest
You can run unit and doctests together at once, using
$ python run-tests.py --quick
.Further checks: