Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduled tests #3091

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Jul 3, 2023

Description

A quick fix to quick the failing doctests step in the scheduled nightly tests, after #3043

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@arjxn-py
Copy link
Member

arjxn-py commented Jul 3, 2023

@agriyakhetarpal macOS tests are also failing randomly, I suggest we also try to fix those in this PR only

@agriyakhetarpal
Copy link
Member Author

I don't think they are failing on our end

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5e28bb9) 99.71% compared to head (e5d498e) 99.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3091   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18749    18749           
========================================
  Hits         18695    18695           
  Misses          54       54           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brosaplanella
Copy link
Member

The mac tests are failing randomly due to some Github issue. It has been solved, but it is being rolled out so still randomly fails (if I understood correctly). I think it is safe to merge.

More info: Homebrew/homebrew-core#135315

@brosaplanella
Copy link
Member

Looks good to me, but didn't quite understand why pandoc is needed.

@agriyakhetarpal
Copy link
Member Author

It is needed for converting the notebooks when building the docs (spatialaudio/nbsphinx#36)

@Saransh-cpp
Copy link
Member

I missed the discussion on this PR in the meet. Is this ready for merging?

@agriyakhetarpal
Copy link
Member Author

We missed discussing this one apparently, should be ready to go

@Saransh-cpp Saransh-cpp merged commit b045644 into pybamm-team:develop Jul 5, 2023
@agriyakhetarpal agriyakhetarpal deleted the fix-scheduled branch July 5, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants