-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance-notebooks #4787
base: develop
Are you sure you want to change the base?
Performance-notebooks #4787
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4787 +/- ##
========================================
Coverage 98.70% 98.70%
========================================
Files 304 304
Lines 23432 23452 +20
========================================
+ Hits 23129 23149 +20
Misses 303 303 ☔ View full report in Codecov by Sentry. |
@MarcBerliner can you check if the changes you made for the training workshop need making here too, or if they are fixed already? thanks! |
Description
Fixes #4772
Adds a sequence of notebooks focusing on understanding the pybamm pipeline and the performance characteristics of the solvers.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest
(or$ nox -s tests
)$ python -m pytest --doctest-plus src
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks: