Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused cylindrical battery geometry support #4875

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

vidipsingh
Copy link
Contributor

Description

This PR removes the handling for cylindrical battery geometry from the battery_geometry function, as it is not used anywhere within the repository and was initially meant for future thermal model extensions.

Fixes: #4856

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@vidipsingh vidipsingh requested a review from a team as a code owner February 25, 2025 19:29
@prady0t
Copy link
Contributor

prady0t commented Feb 25, 2025

If you plan to remove this, you will also need to modify the associated tests. Before opening a PR, run the tests via nox -s unit to get the error log (if any) locally and try to remove them.

@vidipsingh
Copy link
Contributor Author

If you plan to remove this, you will also need to modify the associated tests. Before opening a PR, run the tests via nox -s unit to get the error log (if any) locally and try to remove them.

Thanks for the heads-up! I'll modify the associated tests and run nox -s unit to check for any errors.
I'll update the PR accordingly after resolving them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "cylindrical" macro geometry?
2 participants