Fix Windows build errors

[kratman]

Work in progress while investigating windows build failures

[kratman]

The failure is from VCPKG, I disabled 3.9 as a test just to see if the install works on other python versions

[agriyakhetarpal]

cibuildwheel builds wheels for Python versions incrementally based on values in pyproject.toml; it is unlikely that bumping the minimum Python version would fix it here.

The error from the logs is indeed from Vcpkg:

CMake Error at cmake/tpl/FindKLU.cmake:54 (find_library):
  Could not find KLU_LIBRARY_DEBUG using the following names: klud

[kratman]

Yeah I know, I just wanted to rule out that it was some weird dependency thing. It already failed. I just triggered this while I was in morning meetings

[agriyakhetarpal]

This looks like where the error comes up

"C:/Program Files/CMake/bin/cmake.exe" "C:/vcpkg/buildtrees/sundials/src/v6.5.0-376ddf505a.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" <...>

Vcpkg is trying to build SUNDIALS's triplet in debug mode for some reason, when it has always been built in release mode in the past. We currently capitalise the string in setup.py here:

pybammsolvers/setup.py

Line 93 in 04abfc4

build_type = os.getenv("PYBAMM_CPP_BUILD_TYPE", "RELEASE")

Does it have to be "Release" and not "RELEASE"? This is just a guess; I could be wrong.

[kratman]

This looks like where the error comes up

"C:/Program Files/CMake/bin/cmake.exe" "C:/vcpkg/buildtrees/sundials/src/v6.5.0-376ddf505a.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" <...>

Vcpkg is trying to build SUNDIALS's triplet in debug mode for some reason, when it has always been built in release mode in the past. We currently capitalise the string in setup.py here:

pybammsolvers/setup.py

Line 93 in 04abfc4

build_type = os.getenv("PYBAMM_CPP_BUILD_TYPE", "RELEASE")

Does it have to be "Release" and not "RELEASE"? This is just a guess; I could be wrong.

I will push a change for that to see if it works. It is worth a shot, but weird that it suddenly fails. What I was looking at was just replacing the VCPKG stuff with a full build like we do on linux/mac

[kratman]

I think for this to work, we just need to make klud optional, the other changes for the casadi registry can probably be reverted. Telling VCPKG to build release mode for CasADi and Sundails, appears to still let dependencies build in debug mode. So it does not really seem like a solution that will fix it in the end. I think instead we just need better handling for when the debug/release libraries are not found or figure out if there is something else that broken