pickle setstate: setattr __dict__ only if not empty, to not force use…

… of py::dynamic_attr() unnecessarily.
pybind · Apr 22, 2021 · 61007e9 · 61007e9
1 parent 5443043
commit 61007e9
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/include/pybind11/detail/init.h b/include/pybind11/detail/init.h
@@ -293,6 +293,11 @@ template <typename Class, typename T, typename O,
           enable_if_t<std::is_convertible<O, handle>::value, int> = 0>
 void setstate(value_and_holder &v_h, std::pair<T, O> &&result, bool need_alias) {
     construct<Class>(v_h, std::move(result.first), need_alias);
+    auto d = handle(result.second);
+    if (PyDict_Check(d.ptr()) && PyDict_Size(d.ptr()) == 0) {
+        // Skipping setattr below, to not force use of py::dynamic_attr() for Class unnecessarily.
+        return;
+    }
     setattr((PyObject *) v_h.inst, "__dict__", result.second);
 }