No, I don't have an uninitialized variable

pybind · Jan 22, 2021 · 8356073 · 8356073
1 parent cffc586
commit 8356073
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/include/pybind11/cast.h b/include/pybind11/cast.h
@@ -1044,17 +1044,12 @@ struct type_caster<T, enable_if_t<std::is_arithmetic<T>::value && !is_std_char_t
             return false;
         } else {
             handle src_or_index = src;
+            py_value = (py_type) -1;
 #if PY_VERSION_HEX < 0x03080000
             object index;
-            if (index_check(src.ptr())) {
+            if (!PYBIND11_LONG_CHECK(src.ptr()) && index_check(src.ptr())) {
                 index = reinterpret_steal<object>(PyNumber_Index(src.ptr()));
-                if (!index) {
-                    src_or_index = handle();
-                    py_value = (py_type) -1;
-                }
-                else {
-                    src_or_index = index;
-                }
+                src_or_index = index ? index : handle();
             }
 #endif
             if (src_or_index) {