-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: cleanup and ci hardening #2397
Conversation
3d37b12
to
ec86a98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this PR.
ec86a98
to
e9cda76
Compare
e9cda76
to
19cd759
Compare
I believe 7 or so tests are now passing in PyPy that used to fail (and were hidden by skip instead of xfail), mostly due to better NumPy support in recent PyPy's. |
That's great to hear! :-) |
If I get two approvals, I'll squash and merge. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks Henry!
Refactor the tests. Use a consistent failing/skipping scheme.
Skips/xfails are more consistent, no more
pytest.bug_in_pypy
,pytest.unsupported_on_pypy_lt_6
, etc. (PyPy 7+ required, so ignoring check for old PyPy verisions). No more injection into the pytest module. xfails are reported at the end and most are strictly required. We can usereasons
orraises
to improve the test reporting.