Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update including annotations #2427

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Aug 23, 2020

Adding GitHub Actions annotations. I've been working with @utgwkk on the pytest-github-actions-annotate-failures plugin, and I think it's ready to be used here. (I have commit rights if something breaks - plus it is optional and CI only).

Will likely add the allowed fail properly to the 3.9-dev macOS job, then remove fail-fast false, to improve the quality of the output and speed up tests. Example when a test was intentionally broken below:

Screen Shot 2020-08-23 at 11 25 34 AM

@henryiii henryiii force-pushed the ci/annotations branch 6 times, most recently from 7d1e8f7 to 046d250 Compare August 24, 2020 18:55
@henryiii henryiii marked this pull request as ready for review August 24, 2020 19:05
@henryiii henryiii merged commit 5b59b7b into pybind:master Aug 24, 2020
@henryiii henryiii deleted the ci/annotations branch August 24, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant