Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake status for DOWNLOAD_EIGEN #2857

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Fix CMake status for DOWNLOAD_EIGEN #2857

merged 1 commit into from
Feb 12, 2021

Conversation

OnlineCop
Copy link
Contributor

Description

Fixes documentation for CMake: user is instructed to enable cmake -DDOWNLOAD_EIGEN but -D requires a key=value pair: cmake -DDOWNLOAD_EIGEN=ON

@bstaletic
Copy link
Collaborator

Cmake format is complaining.

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index bcc793b..9ff6c0d 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -225,7 +225,8 @@ if(PYBIND11_TEST_FILES_EIGEN_I GREATER -1)
     message(STATUS "Building tests with Eigen v${EIGEN3_VERSION}")
   else()
     list(REMOVE_AT PYBIND11_TEST_FILES ${PYBIND11_TEST_FILES_EIGEN_I})
-    message(STATUS "Building tests WITHOUT Eigen, use -DDOWNLOAD_EIGEN=ON on CMake 3.11+ to download")
+    message(
+      STATUS "Building tests WITHOUT Eigen, use -DDOWNLOAD_EIGEN=ON on CMake 3.11+ to download")
   endif()
 endif()

@henryiii henryiii merged commit cbae6d5 into pybind:master Feb 12, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 12, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants