Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointing out namespace in docs #2874

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Pointing out namespace in docs #2874

merged 1 commit into from
Feb 25, 2021

Conversation

tdegeus
Copy link
Contributor

@tdegeus tdegeus commented Feb 24, 2021

Description

Suggested changelog entry:

@tdegeus tdegeus changed the base branch from stable to master February 24, 2021 17:31
@YannickJadoul YannickJadoul reopened this Feb 24, 2021
Copy link
Collaborator

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect anyone to object against this one? (Not exactly the most drastic or urgent change, but thanks for taking the time to turn it into a PR when spotting it, @tdegeus!)

@rwgk rwgk merged commit 9c0aa69 into pybind:master Feb 25, 2021
@rwgk
Copy link
Collaborator

rwgk commented Feb 25, 2021

Thanks Tom & Yannick!

@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 25, 2021
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Feb 25, 2021
@tdegeus tdegeus deleted the patch-1 branch February 25, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants