Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: pragma block reduction #3125

Closed
wants to merge 36 commits into from
Closed

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jul 16, 2021

Spreadsheet: pybind11.h v2.7.0 pragma block analysis

Approach:

for pragma in pragmas:
    remove_from_pybind11_h(pragma)
    run_ci_with_tests_disabled()
    collect_logs()
manually_sort_through_logs()
manually_add_local_pragma_push_pop()

Keeping track of some simple results here:

  • GCC -Wunused-but-set-parameter needs work
  • GCC -Wunused-but-set-variable rm_ok
  • GCC -Wmissing-field-initializers rm_ok
  • GCC -Wattributes needs work
  • GCC -Wnoexcept-type needs work (gcc 7 only)
  • MSVC C4100 needs work
  • MSVC C4127 needs work
  • MSVC C4512 rm_ok
  • MSVC C4800 needs work
  • MSVC C4996 needs work
  • MSVC C4702 rm_ok
  • MSVC C4522 needs work
  • MSVC C4505 needs work
  • ICC 186 rm_ok
  • ICC 878 needs work
  • ICC 1334 rm_ok
  • ICC 1682 rm_ok
  • ICC 1786 rm_ok
  • ICC 1875 rm_ok
  • ICC 2196 needs work

@rwgk rwgk force-pushed the pragma_block_reduction branch from 0089c6d to 9b335de Compare July 16, 2021 04:43
@rwgk rwgk force-pushed the pragma_block_reduction branch from d2a7663 to e7b7352 Compare July 17, 2021 03:40
@rwgk
Copy link
Collaborator Author

rwgk commented Aug 14, 2021

This work was completed.

@rwgk rwgk closed this Aug 14, 2021
@rwgk rwgk deleted the pragma_block_reduction branch August 14, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant