Experiments on top of PR #3643 (pybind11_select_caster) #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
force-pushed
the
adl-caster_sandbox_pr
branch
from
0401bda to
21763f2
Compare
amauryfa
reviewed
Feb 3, 2022
| in every compilation unit of the Python extension module. Otherwise, | ||
| undefined behavior can ensue. | ||
|
|
||
| * The preferred method is to *declare* a function named |
There was a problem hiding this comment.
"When you own the namespace where the type is defined, the preferred method..."
- There is no ODR violation when different translation units define different conversions. - The declarations need to be defined in the original namespace.
"explicit specialization 'void pybind11::detail::cast_safe<void>(pybind11::object &&)' is not a specialization of a function template"
rwgk
force-pushed
the
adl-caster_sandbox_pr
branch
from
6db1e04 to
dfd923d
Compare
|
The force push was purely for |
rwgk
pushed a commit
that referenced
this pull request
Apr 11, 2022
* Cleanup cast_safe<void> specialization Replace explicit specialization of cast_safe<void> with SFINAE. It's better for SFINAE cases to cover all type-sets rather than mixing SFINAE and explicit specialization. Extracted from #3674 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update cast.h Use detail::none_of<> as suggested * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update cast.h Reorder: If TEMP_REF If VOID if (!VOID && !TEMP_REF) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
laramiel
added a commit
to laramiel/pybind11
that referenced
this pull request
Apr 11, 2022
|
I have reworked this on top of HEAD with #3862 |
|
Work continued under #3862. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP on top of #3643.
Suggested changelog entry: