-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXPERIMENTAL clang-tidy readability-braces-around-statements #3698
Closed
rwgk
wants to merge
7
commits into
pybind:master
from
rwgk:clang-tidy_readability-braces-around-statements
Closed
EXPERIMENTAL clang-tidy readability-braces-around-statements #3698
rwgk
wants to merge
7
commits into
pybind:master
from
rwgk:clang-tidy_readability-braces-around-statements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill builds & tests succeed.
rwgk
force-pushed
the
clang-tidy_readability-braces-around-statements
branch
from
February 7, 2022 20:34
47df05c
to
ffa3eed
Compare
Just for entertainment, this (original)
really threw
into a tail spin. Note that clang-tidy made several other mistakes around other Final correctly working version:
|
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Feb 8, 2022
…d-statements. Informed by experiments under PR pybind#3698.
rwgk
changed the title
clang-tidy readability-braces-around-statements
EXPERIMENTAL clang-tidy readability-braces-around-statements
Feb 8, 2022
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Feb 8, 2022
…d-statements. Informed by experiments under PR pybind#3698.
rwgk
pushed a commit
that referenced
this pull request
Feb 8, 2022
…d-statements. Informed by experiments under PR #3698.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The work under this experimental PR was used to inform PR #3699.
Suggested changelog entry: