-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix & test for issue #4288 (unicode surrogate character in Python exception message). #4297
Merged
henryiii
merged 4 commits into
pybind:master
from
rwgk:error_already_set_unicode_surrogate
Oct 31, 2022
Merged
Fix & test for issue #4288 (unicode surrogate character in Python exception message). #4297
henryiii
merged 4 commits into
pybind:master
from
rwgk:error_already_set_unicode_surrogate
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on exception message).
PyPy 3.7 Windows gave:
That's the expected flake, or something else? Either way, I can rerun. You can access old runs at the top of the checks screen, there's a selectable run number there. |
henryiii
reviewed
Oct 31, 2022
Something else. I've seen it for the first time 2-3 months ago. I don't know what's behind it, at all. But clearly not related to this PR. |
Skylion007
reviewed
Oct 31, 2022
Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com>
Skylion007
approved these changes
Oct 31, 2022
Skylion007
approved these changes
Oct 31, 2022
henryiii
added a commit
that referenced
this pull request
Oct 31, 2022
* Fix & test for issue #4288 (unicode surrogate character in Python exception message). * DRY `message_unavailable_exc` * fix: add a constexpr Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> * style: pre-commit fixes Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com> Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
rwgk
added a commit
that referenced
this pull request
Nov 18, 2022
* Fix & test for issue #4288 (unicode surrogate character in Python exception message). * DRY `message_unavailable_exc` * fix: add a constexpr Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> * style: pre-commit fixes Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com> Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4288. See there for background.
While at it:
test_error_already_set_message_with_malformed_utf8()
(passes without changes).Suggested changelog entry:
Bug fix: Unicode surrogate character in Python exception message leads to process termination in `error_already_set::what()`.