Improve the error reporting for inc_ref GIL failures #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Skylion007 @henryiii I know this sucks, but I think you might want to push this out ASAP given all the issues with 2.10.2 Might be worth rereleasing 2.10.2 with this patch or pushing out 2.10.3 |
Skylion007
reviewed
Dec 27, 2022
Skylion007
reviewed
Dec 27, 2022
rwgk
reviewed
Dec 27, 2022
|
I don't remember seeing the pypy-3.7 • windows-2022 • x64 CI failure. Rerunning to be sure it's a flake. |
|
I believe all of the comments are now resolved. Thanks for the feedback and reviews! |
rwgk
approved these changes
Dec 28, 2022
rwgk
reviewed
Dec 29, 2022
|
Could someone else please merge this? (@henryiii or @Skylion007) |
henryiii
approved these changes
Dec 30, 2022
rwgk
pushed a commit
to google/clif
that referenced
this pull request
Jan 1, 2023
…pointer. Context: * pybind/pybind11#4427 (comment) > I don't think your logic ... is actually correct? I don't think it would handle metaclasses right. PiperOrigin-RevId: 498690703
henryiii
pushed a commit
that referenced
this pull request
Jan 2, 2023
* First * Fixs * Improve * Additional assertions comment * Improve docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 2.10.2, we added a new feature to catch UB when inc_ref or dec_ref are called without the GIL. This functionality works great, but the error reporting via an exception is very suboptimal as those exceptions get called in weird environments, triggering weird crashes.
This PR adds some good old-fashioned fprintf statements to help users understand what is going on. I want to use fprintf here because that's generally the most reliable method in all sorts of environments (especially when iostream might not be initialized properly).
Closes #4426
Suggested changelog entry: