Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang15 C++20 job #4443

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add clang15 C++20 job #4443

merged 1 commit into from
Jan 13, 2023

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jan 4, 2023

Description

Just keeping up.

Suggested changelog entry:

@rwgk rwgk requested a review from Skylion007 January 4, 2023 05:09
@rwgk rwgk marked this pull request as ready for review January 4, 2023 05:09
@rwgk rwgk requested a review from henryiii as a code owner January 4, 2023 05:09
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we don't need all the in-between jobs - just the first and last compiler for each C++ mode would be fine. Also, I think all the tags (at least the maintained ones) now have the -bullseye suffix.

@rwgk rwgk merged commit d821788 into pybind:master Jan 13, 2023
@rwgk rwgk deleted the add_clang15_cpp20 branch January 13, 2023 01:50
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jan 13, 2023
@rwgk
Copy link
Collaborator Author

rwgk commented Jan 13, 2023

What are the pros-and-cons for omitting some clang versions?

Pros:

  • Reduce carbon footprint.

I cannot think of anything else: the CI will not finish any faster, it doesn't cost us anything, the resources are paid for already.

Cons:

  • General: if it's not tested, it might be broken. No compiler is bug free.
  • When figuring out compiler-specific ifdefs we don't have all the data we need. (I was in that situation several times.)
  • When experimenting with what compiler supports a certain C++ feature, we don't have all the data we need.
  • If/when we want to do performance analyses, we don't have all the data we need.
  • Deciding what versions to cover requires human cycles (guesswork), as for example right now. We could do something else with our time.

@Skylion007
Copy link
Collaborator

Yeah, feel free to have all the clang-versions. I think we just might want to add bullseye to some other containers so it uses the latest version :P

@rwgk
Copy link
Collaborator Author

rwgk commented Jan 13, 2023

The CI after merging this PR had 6 failures, all seem ubuntu related, apt-get failures. Does someone know already what we need to do to get back to normal?

@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jan 13, 2023
@Skylion007
Copy link
Collaborator

Not seeing any failure?

@rwgk
Copy link
Collaborator Author

rwgk commented Jan 13, 2023

Apparently @henryiii triggered a rerun, and then all failed jobs succeeded:

  1. https://github.com/pybind/pybind11/actions/runs/3907641043/attempts/1
  2. https://github.com/pybind/pybind11/actions/runs/3907641043

Nice! Back to normal with a couple clicks.

henryiii pushed a commit that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants