Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure import pybind11_tests traceback is shown. #4455

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jan 14, 2023

Description

Not seeing the primary failure reason can be (has been) very confusing during development. (Concretely, I lost good chunks of time while working on PRs #1895 and #4329.)

Suggested changelog entry:

@rwgk rwgk marked this pull request as ready for review January 14, 2023 02:50
@rwgk rwgk requested review from henryiii and Skylion007 January 14, 2023 02:50
@Skylion007 Skylion007 merged commit e53d58a into pybind:master Jan 14, 2023
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jan 14, 2023
@rwgk rwgk deleted the import_pybind11_tests_traceback branch January 16, 2023 02:01
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jan 16, 2023
@rwgk
Copy link
Collaborator Author

rwgk commented Jan 16, 2023

Thanks Aaron!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants